Messages in this thread | | | Date | Mon, 12 Sep 2016 15:40:10 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH for-next 02/10] IB/hns: Register add_gid and del_gid for GID Table management |
| |
On Fri, Sep 02, 2016 at 05:37:17AM +0800, Salil Mehta wrote: > From: Lijun Ou <oulijun@huawei.com> > > This patch adds support of add_gid() and del_gid() function in the > HNS RoCE driver for manipulation of the GID table associated with > port. This shall be used be used by CM when connection is > established. > > Signed-off-by: Lijun Ou <oulijun@huawei.com> > Reviewed-by: Wei Hu <xavier.huwei@huawei.com> > Signed-off-by: Salil Mehta <salil.mehta@huawei.com> > --- > drivers/infiniband/hw/hns/hns_roce_main.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c > index 39e69c3..4e93120 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_main.c > +++ b/drivers/infiniband/hw/hns/hns_roce_main.c > @@ -158,6 +158,19 @@ static void hns_roce_update_gids(struct hns_roce_dev *hr_dev, int port) > ib_dispatch_event(&event); > } > > +static int hns_roce_add_gid(struct ib_device *device, u8 port_num, > + unsigned int index, const union ib_gid *gid, > + const struct ib_gid_attr *attr, void **context) > +{ > + return 0; > +} > + > +static int hns_roce_del_gid(struct ib_device *device, u8 port_num, > + unsigned int index, void **context) > +{ > + return 0; > +}
This patch makes no sense to me. It is the same as not write this functions at all.
> + > static int handle_en_event(struct hns_roce_dev *hr_dev, u8 port, > unsigned long event) > { > @@ -639,6 +652,8 @@ static int hns_roce_register_device(struct hns_roce_dev *hr_dev) > ib_dev->get_link_layer = hns_roce_get_link_layer; > ib_dev->get_netdev = hns_roce_get_netdev; > ib_dev->query_gid = hns_roce_query_gid; > + ib_dev->add_gid = hns_roce_add_gid; > + ib_dev->del_gid = hns_roce_del_gid; > ib_dev->query_pkey = hns_roce_query_pkey; > ib_dev->alloc_ucontext = hns_roce_alloc_ucontext; > ib_dev->dealloc_ucontext = hns_roce_dealloc_ucontext; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [unhandled content-type:application/pgp-signature] | |