lkml.org 
[lkml]   [2016]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] powerpc/32: add missing \n at end of printk warning message
Date
Christophe Leroy <christophe.leroy@c-s.fr> writes:

> Le 12/09/2016 à 12:12, Colin King a écrit :
>> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
>> index 448685f..b532dd9 100644
>> --- a/arch/powerpc/mm/init_32.c
>> +++ b/arch/powerpc/mm/init_32.c
>> @@ -137,7 +137,7 @@ void __init MMU_init(void)
>> if (memblock.memory.cnt > 1) {
>> #ifndef CONFIG_WII
>> memblock_enforce_memory_limit(memblock.memory.regions[0].size);
>> - printk(KERN_WARNING "Only using first contiguous memory region");
>> + printk(KERN_WARNING "Only using first contiguous memory region\n");
>
> This line was already 81 characters long. It is now 83.

That doesn't really bother me.

> I would suggest to use pr_warn() instead in order to shorten the line.

But I do like pr_warn(), it's less shouty.

I'll fix it up when I apply it.

cheers

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.048 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site