lkml.org 
[lkml]   [2016]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?
On Mon, Jul 18, 2016 at 01:29:05PM +0100, David Binderman wrote:
> Hello there,
>
> drivers/usb/usbip/vudc_rx.c:145:27: warning: result of ‘11 << 30’
> requires 35 bits to represent, but ‘int’ only has 32 bits
> [-Wshift-overflow=]
>
> Source code is
>
> urb_p->urb->pipe &= ~(11 << 30);
>
> Maybe better code
>
> urb_p->urb->pipe &= ~(11UL << 30);

Perhaps, care to send a patch?

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-08-09 16:41    [W:0.064 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site