lkml.org 
[lkml]   [2016]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] usb: ehci-platform: use helper variables in probe function
On Fri, Jul 15, 2016 at 07:05:56AM +0200, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> ---
> V2: Use 2 extra tabs after line break to match one of already used
> coding styles.

Same comment here, unnecessary churn, sorry.

greg k-h

\
 
 \ /
  Last update: 2016-08-09 16:41    [W:0.079 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site