Messages in this thread | | | From | Daniel Vetter <> | Date | Tue, 9 Aug 2016 15:56:15 +0200 | Subject | Re: [PATCH] Revert "Revert "doc/sphinx: Enable keep_warnings"" |
| |
On Mon, Aug 8, 2016 at 11:32 PM, Jonathan Corbet <corbet@lwn.net> wrote: > On Mon, 8 Aug 2016 18:23:11 +0200 > Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > >> Even with Markus fixes to the importer I still get warnigns from >> sphinx which are entirely bogus :( >> >> /home/daniel/linux/src/Documentation/gpu/drm-kms.rst:13: WARNING: Could not lex literal_block as "C". Highlighting skipped. >> /home/daniel/linux/src/Documentation/gpu/drm-kms-helpers.rst:16: WARNING: Could not lex literal_block as "C". Highlighting skipped. >> /home/daniel/linux/src/Documentation/gpu/i915.rst:57: WARNING: Could not lex literal_block as "C". Highlighting skipped. >> >> Well it's worse: Those are warnings which don't even show up with this >> enabled. Just sending this out again in the hopes some has a clue >> what's going on. > > So I honestly think we should just set the highlight language to "none" by > default. The syntax highlighting in code samples adds some colorful sugar > to the docs, but it's not really all that useful, IMO, and people who want > it can override the language in the right places. > > Any strong opposition to this idea?
Hm right, didn't realize that this is where it's coming from. No strong opinion from my side on highlighting the C block quotes really. Otoh that highlighting is rather pretty. Could we perhaps just shut sphinx up about the "C" highlighting issues? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
| |