lkml.org 
[lkml]   [2016]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test
On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote :
>
>
> On Tue, 9 Aug 2016, Christophe JAILLET wrote:
>
> > It is likely that checking the result of 'pcf2123_write_reg' is expected
> > here.
> > Also fix a small style issue. The '{' at the beginning of the function
> > is misplaced.
>
> They shouldn't be in the same patch. If you are wrong about the ret
> issue, the { should still be moved.
>

That is true but as it is a really trivial patch, I didn't care that
much.


--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2016-08-09 15:01    [W:0.049 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site