Messages in this thread | | | Date | Tue, 9 Aug 2016 14:17:53 +0200 | From | Alexandre Belloni <> | Subject | Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test |
| |
On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote : > > > On Tue, 9 Aug 2016, Christophe JAILLET wrote: > > > It is likely that checking the result of 'pcf2123_write_reg' is expected > > here. > > Also fix a small style issue. The '{' at the beginning of the function > > is misplaced. > > They shouldn't be in the same patch. If you are wrong about the ret > issue, the { should still be moved. >
That is true but as it is a really trivial patch, I didn't care that much.
-- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |