lkml.org 
[lkml]   [2016]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 02/14] net: ethernet: ti: cpsw: remove redundant check in napi poll
    From
    Date


    On 09.08.16 14:29, Grygorii Strashko wrote:
    > On 08/06/2016 01:48 PM, Ivan Khoronzhuk wrote:
    >> No need to check number of handled packets, when in most cases (> 99%)
    >> it's not 0. It can be 0 only in rare cases, even in this case
    >> it's not bad to print just 0.
    >>
    >> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
    >> ---
    >> drivers/net/ethernet/ti/cpsw.c | 8 ++------
    >> 1 file changed, 2 insertions(+), 6 deletions(-)
    >>
    >> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
    >> index 8972bf6..85ee9f5 100644
    >> --- a/drivers/net/ethernet/ti/cpsw.c
    >> +++ b/drivers/net/ethernet/ti/cpsw.c
    >> @@ -793,9 +793,7 @@ static int cpsw_tx_poll(struct napi_struct *napi_tx, int budget)
    >> }
    >> }
    >>
    >> - if (num_tx)
    >> - cpsw_dbg(priv, intr, "poll %d tx pkts\n", num_tx);
    >> -
    >> + cpsw_dbg(priv, intr, "poll %d tx pkts\n", num_tx);
    >
    > I think, this dbg log can be just dropped as it seems not very useful.
    > This also will allow to drop patch [PATCH v2 12/14] net: ethernet: ti: cpsw: fix int dbg message
    That was my first thought, but I worried about someone can use it.
    If no one has objection, I'll drop the patch 12 and delete "poll" print at all.

    >
    >> return num_tx;
    >> }
    >>
    >> @@ -814,9 +812,7 @@ static int cpsw_rx_poll(struct napi_struct *napi_rx, int budget)
    >> }
    >> }
    >>
    >> - if (num_rx)
    >> - cpsw_dbg(priv, intr, "poll %d rx pkts\n", num_rx);
    >> -
    >> + cpsw_dbg(priv, intr, "poll %d rx pkts\n", num_rx);
    >
    > Same here.
    >
    >> return num_rx;
    >> }
    >>
    >>
    >
    >

    --
    Regards,
    Ivan Khoronzhuk

    \
     
     \ /
      Last update: 2016-08-09 14:41    [W:5.238 / U:1.716 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site