lkml.org 
[lkml]   [2016]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 32/68] pinctrl: single: Fix missing flush of posted write for a wakeirq
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tony Lindgren <tony@atomide.com>

    commit 0ac3c0a4025f41748a083bdd4970cb3ede802b15 upstream.

    With many repeated suspend resume cycles, the pin specific wakeirq
    may not always work on omaps. This is because the write to enable the
    pin interrupt may not have reached the device over the interconnect
    before suspend happens.

    Let's fix the issue with a flush of posted write with a readback.

    Reported-by: Nishanth Menon <nm@ti.com>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pinctrl/pinctrl-single.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/pinctrl/pinctrl-single.c
    +++ b/drivers/pinctrl/pinctrl-single.c
    @@ -1576,6 +1576,9 @@ static inline void pcs_irq_set(struct pc
    else
    mask &= ~soc_mask;
    pcs->write(mask, pcswi->reg);
    +
    + /* flush posted write */
    + mask = pcs->read(pcswi->reg);
    raw_spin_unlock(&pcs->lock);
    }


    \
     
     \ /
      Last update: 2016-08-08 22:21    [W:2.335 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site