lkml.org 
[lkml]   [2016]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Revert "of/irq: Mark initialised interrupt controllers as populated"
On Mon, Aug 8, 2016 at 11:47 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> This reverts commit 15cc2ed6dcf91a8658e084be4e140147161819d7 ("of/irq:
> Mark initialised interrupt controllers as populated"), which breaks the
> i.MX6 GPC (General Power Controller). The GPC is both an interrupt
> controller and a power domain controller. If the interrupt code sets the
> OF_POPULATED bit early, the power domain driver is silently skipped, as
> are the GPU and VPU drivers that are missing their power domain.

What makes the GPC need to be handled early as an interrupt
controller? Looks like the timer is not dependent on it, so maybe it
can be converted to a regular driver?

A simple alternative here would be to set the OF_POPULATED before the
callback function is called, so your GPC callback can clear it.

Rob

>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Cc: Rob Herring <robh@kernel.org>
> ---
> drivers/of/irq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index 89a71c6..7d3f93f 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -559,8 +559,6 @@ void __init of_irq_init(const struct of_device_id *matches)
> * its children can get processed in a subsequent pass.
> */
> list_add_tail(&desc->list, &intc_parent_list);
> -
> - of_node_set_flag(desc->dev, OF_POPULATED);
> }
>
> /* Get the next pending parent that might have children */
> --
> 2.8.1
>

\
 
 \ /
  Last update: 2016-08-08 19:41    [W:0.066 / U:1.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site