Messages in this thread | | | From | Mathieu Poirier <> | Date | Mon, 8 Aug 2016 08:38:18 -0600 | Subject | Re: [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux() |
| |
On 8 August 2016 at 04:49, Alexander Shishkin <alexander.shishkin@linux.intel.com> wrote: > Peter Zijlstra <peterz@infradead.org> writes: > >> On Thu, Jul 28, 2016 at 03:42:19PM -0600, Mathieu Poirier wrote: >>> Some information, like driver specific configuration, is found >>> in the hw_perf_event structure. As such pass a 'struct perf_event' >>> to function setup_aux() rather than just the CPU number so that >>> individual drivers can make the right configuration when setting >>> up a session. >>> >>> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> >>> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> >> >> Yeah, no objection to this. > > Sure, but I'd like a commit message that actually describes *what* > information and *why*.
Sure, I'll make it more explicit in the next revision.
Mathieu
> > Regards, > -- > Alex
| |