lkml.org 
[lkml]   [2016]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sunrpc: Remove unnecessary variable
From
Date
On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote:
> The variable `err` is not used anywhere and just returns the
> predefined value `0` at the end of the function. Hence, remove the
> variable and return 0 explicitly.

Makes sense to me. Thanks!

Anna

>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> net/sunrpc/clnt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index b7f2104..0a775fa 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -184,7 +184,6 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
> struct super_block *sb)
> {
> struct dentry *dentry;
> - int err = 0;
>
> switch (event) {
> case RPC_PIPEFS_MOUNT:
> @@ -201,7 +200,7 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
> printk(KERN_ERR "%s: unknown event: %ld\n", __func__, event);
> return -ENOTSUPP;
> }
> - return err;
> + return 0;
> }
>
> static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event,
>

\
 
 \ /
  Last update: 2016-08-08 16:21    [W:0.037 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site