Messages in this thread | | | From | Paul Gortmaker <> | Date | Fri, 5 Aug 2016 19:04:53 -0400 | Subject | Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC |
| |
On Fri, Aug 5, 2016 at 7:00 PM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig >> index fa33c50..a6f90c5 100644 >> --- a/drivers/irqchip/Kconfig >> +++ b/drivers/irqchip/Kconfig >> @@ -246,6 +246,9 @@ config MVEBU_ODMI >> bool >> select GENERIC_MSI_IRQ_DOMAIN >> >> +config MVEBU_PIC >> + bool > > Please switch to a builtin registration call, and remove module.h and > all the MODULE_<xyz> references since this is a bool and not a > tristate Kconfig.
I overlooked that someone else beat me to making the bool/tristate comment -- oh well, that is a good thing that it is on other people's minds too now. Apologies for the duplicated feedback.
Paul.
| |