Messages in this thread | | | Subject | Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput | From | Johannes Berg <> | Date | Fri, 05 Aug 2016 17:34:21 +0200 |
| |
On Fri, 2016-08-05 at 13:25 +0000, Altshul, Maxim wrote: > Hi, > 1) Sorry about the change log, I will try to be clearer next time.
Just mention something about how the bug happens please, at least.
> 2+3) The issue is not that the station is not known, it's that > wl_sta->wl was null. > wl member is now completely removed from wl_sta (PATCH 2/2) and hw is > sent directly from mac80211 to the driver (so it can get hw->priv).
Right, I understand that wl_sta->wl was NULL. But the driver must have some code to assign wl_sta->wl, right? And that would be called in add_sta or sta_state. Thus the reason for the crash would be that the station wasn't actually known to the driver yet.
Even if that wasn't quite the reason here, I think we need to take it into account and check sta->uploaded before calling the driver, so I'd like you to submit a patch for that.
johannes
| |