Messages in this thread | | | Subject | Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput | From | Johannes Berg <> | Date | Fri, 05 Aug 2016 14:24:40 +0200 |
| |
On Fri, 2016-08-05 at 14:22 +0200, Johannes Berg wrote: > On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote: > > - The variable is added to allow the driver an easy access > > to it's own hw->priv when the op is invoked. > > > > - Change wlcore op accordingly. > > > I'm applying this now, with a big BUT: > > 1) your changelog is crap - I've rewritten it to indicate what's > going > on > > 2) I think the change makes sense, but as far as fixing the bug is > concerned it's actually completely stupid > > 3) I expect you to submit a proper bugfix for mac80211 ASAP, to not > call into the driver before the station is actually known to the > driver.
4) please indent your code properly when submitting...
johannes
| |