lkml.org 
[lkml]   [2016]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41
On Thu, Aug 04, 2016 at 05:58:26PM -0700, Stephen Boyd wrote:
> On 07/11, Andy Gross wrote:
> > On Mon, Jul 11, 2016 at 02:50:07PM -0700, Stephen Boyd wrote:
> >
> > > static const struct regulator_desc pm8941_pldo = {
> > > .linear_ranges = (struct regulator_linear_range[]) {
> > > - REGULATOR_LINEAR_RANGE( 750000, 0, 30, 25000),
> > > - REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000),
> > > + REGULATOR_LINEAR_RANGE( 750000, 0, 63, 12500),
> > > + REGULATOR_LINEAR_RANGE(1550000, 64, 126, 25000),
> > > + REGULATOR_LINEAR_RANGE(3100000, 127, 163, 50000),
> > > },
> > > - .n_linear_ranges = 2,
> > > - .n_voltages = 100,
> > > + .n_linear_ranges = 3,
> > > + .n_voltages = 164,
> > > .ops = &rpm_smps_ldo_ops,
> > > };
> >
> > Still a little confused on if the 12.5mV is allowed on pmos ldo. It seems like the
> > nmos has 1 range of 5mV steps. The PMOS has 2 ranges, using 25mV and 50mV
> >
>
> The values I've put in these patches are the correct ranges.

Ok. As with the other patch:

Reviewed-by: Andy Gross <andy.gross@linaro.org>

\
 
 \ /
  Last update: 2016-08-05 07:02    [W:0.035 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site