lkml.org 
[lkml]   [2016]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 17/44] proc: fix return address printk conversion specifer in /proc/<pid>/stack
    Date
    When printing call return addresses found on a stack, /proc/<pid>/stack
    can sometimes give a confusing result. If the call instruction was the
    last instruction in the function (which can happen when calling a
    noreturn function), '%pS' will incorrectly display the name of the
    function which happens to be next in the object code, rather than the
    name of the actual calling function.

    Use '%pB' instead, which was created for this exact purpose.

    Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
    ---
    fs/proc/base.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/proc/base.c b/fs/proc/base.c
    index 31370da..cc4d81c 100644
    --- a/fs/proc/base.c
    +++ b/fs/proc/base.c
    @@ -483,7 +483,7 @@ static int proc_pid_stack(struct seq_file *m, struct pid_namespace *ns,
    save_stack_trace_tsk(task, &trace);

    for (i = 0; i < trace.nr_entries; i++) {
    - seq_printf(m, "[<%pK>] %pS\n",
    + seq_printf(m, "[<%pK>] %pB\n",
    (void *)entries[i], (void *)entries[i]);
    }
    unlock_trace(task);
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-08-05 01:01    [W:2.082 / U:0.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site