lkml.org 
[lkml]   [2016]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers
From
Date


在 2016/8/31 19:48, Arnd Bergmann 写道:
> On Wednesday, August 31, 2016 7:48:14 PM CEST Dongdong Liu wrote:
>> +static struct hisi_rc_res rc_res[] = {
>> + {
>> + HIP05,
>> + {
>> + DEFINE_RES_MEM(0xb0070000, SZ_4K),
>> + DEFINE_RES_MEM(0xb0080000, SZ_4K),
>> + DEFINE_RES_MEM(0xb0090000, SZ_4K),
>> + DEFINE_RES_MEM(0xb00a0000, SZ_4K)
>> + }
>> + },
>> + {
>> + HIP06,
>> + {
>> + DEFINE_RES_MEM(0xa0090000, SZ_4K),
>> + DEFINE_RES_MEM(0xa0200000, SZ_4K),
>> + DEFINE_RES_MEM(0xa00a0000, SZ_4K),
>> + DEFINE_RES_MEM(0xa00b0000, SZ_4K)
>> + }
>> + },
>> + {
>> + HIP07,
>> + {
>> + DEFINE_RES_MEM(0xa0090000, SZ_4K),
>> + DEFINE_RES_MEM(0xa0200000, SZ_4K),
>> + DEFINE_RES_MEM(0xa00a0000, SZ_4K),
>> + DEFINE_RES_MEM(0xa00b0000, SZ_4K),
>> + DEFINE_RES_MEM(0x8a0090000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x8a0200000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x8a00a0000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x8a00b0000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x600a0090000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x600a0200000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x600a00a0000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x600a00b0000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x700a0090000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x700a0200000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x700a00a0000UL, SZ_4K),
>> + DEFINE_RES_MEM(0x700a00b0000UL, SZ_4K)
>> + }
>> + },
>
> I don't know much about ACPI, but I'm pretty sure this is not
> the normal way to find MMIO resources. Why not read them from
> the ACPI tables?
>

Hi Arnd

Our host bridge is non ECAM only for the RC bus config space;
for any other bus underneath the root bus we support ECAM access.

We have not found a comfortable ACPI way to describle RC itself config (not ECAM) resource .


Thanks
Dongdong

> Arnd
>
> .
>

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:4.985 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site