Messages in this thread | | | Date | Wed, 31 Aug 2016 09:26:54 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH] cpufreq: Drop unnecessary check from cpufreq_policy_alloc() |
| |
On 31-08-16, 03:11, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Since cpufreq_policy_alloc() doesn't use its dev variable for > anything useful, drop that variable from there along with the > NULL check against it. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/cpufreq/cpufreq.c | 4 ---- > 1 file changed, 4 deletions(-) > > Index: linux-pm/drivers/cpufreq/cpufreq.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/cpufreq.c > +++ linux-pm/drivers/cpufreq/cpufreq.c > @@ -1073,13 +1073,9 @@ static void handle_update(struct work_st > > static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) > { > - struct device *dev = get_cpu_device(cpu); > struct cpufreq_policy *policy; > int ret; > > - if (WARN_ON(!dev)) > - return NULL; > - > policy = kzalloc(sizeof(*policy), GFP_KERNEL); > if (!policy) > return NULL;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |