lkml.org 
[lkml]   [2016]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v11 2/4] tee: generic TEE subsystem
From
Date
On 08/22/2016 08:00 AM, Jens Wiklander wrote:
> +/*
> + * Unprivileged devices in the in the lower half range and privileged

^^ in the in the
[snip]

> +
> + rc = alloc_chrdev_region(&tee_devt, 0, TEE_NUM_DEVICES, "tee");
> + if (rc < 0) {

if (rc) ?

[snip]

> + * Memory allocated as global shared memory is automatically freed when the
> + * TEE file pointer is closed. The @flags field uses the bits defined by
> + * TEE_SHM_* above. TEE_SHM_MAPPED must currently always be set. If

^^^ not really above anymore, out of file now looks like

> + * TEE_SHM_DMA_BUF global shared memory will be allocated and associated
> + * with a dma-buf handle, else driver private memory.
> + *
> + * @returns a pointer to 'struct tee_shm'

Doesn't say anything, is this really needed?

[snip]

> +/**
> + * struct tee_shm_pool_mem_info - holds information needed to create a shared
> + * memory pool
> + * @vaddr: Virtual address of start of pool
> + * @paddr: Physical address of start of pool
> + * @size: Size in bytes of the pool
> + */
> +struct tee_shm_pool_mem_info {
> + unsigned long vaddr;
> + unsigned long paddr;

phys_addr_t paddr; ?

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.133 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site