Messages in this thread | | | Subject | Re: [PATCH 25/26] clk: boston: Add a driver for MIPS Boston board clocks | From | Paul Burton <> | Date | Tue, 30 Aug 2016 16:06:12 +0100 |
| |
On 26/08/16 18:41, Stephen Boyd wrote: >> + if (err) >> + pr_err("failed to add DT provider: %d\n", err); >> +} >> +CLK_OF_DECLARE(clk_boston, "img,boston-clock", clk_boston_setup); > > Please make this into a platform driver.
Hi Stephen,
The problem with this would be that we need to obtain the CPU clock rate fairly early during boot in order to set up the clocksource & delay loop etc. Using CLK_OF_DECLARE allows for that but if this were a platform driver my understanding is that the clocks wouldn't become available until some point later in boot. If I'm wrong & there's a way to avoid that please let me know.
Also: why? If CLK_OF_DECLARE isn't liked, shouldn't that be documented somewhere (ideally next to the declaration of CLK_OF_DECLARE in include/linux/clk-provider.h)?
Thanks, Paul
| |