Messages in this thread | | | From | Joel Stanley <> | Date | Tue, 30 Aug 2016 15:34:34 +0930 | Subject | Re: [PATCH v2 5/8] pinctrl: Add core support for Aspeed SoCs |
| |
On Tue, Aug 23, 2016 at 12:00 PM, Andrew Jeffery <andrew@aj.id.au> wrote: > On Mon, 2016-08-22 at 15:45 +0200, Linus Walleij wrote: >> On Fri, Aug 19, 2016 at 2:44 PM, Andrew Jeffery <andrew@aj.id.au> wrote: >> >> > >> > +++ b/drivers/pinctrl/aspeed/Kconfig >> > @@ -0,0 +1,8 @@ >> > +config PINCTRL_ASPEED >> > + bool >> > + depends on (ARCH_ASPEED || COMPILE_TEST) && OF >> > + select PINMUX >> > + select PINCONF >> > + select GENERIC_PINCONF >> > + select MFD_SYSCON >> > + select REGMAP_MMIO >> Since this device is spawn from the syscon, should it not be >> "depends on MFD_SYSCON"? >> >> (No big deal, if you think this is right then go with it.) > > I think that's a fair point, I will look at rearranging it.
As discussed, lets go with Linus' suggestion.
>> >> The expression core engine is still a complete mystery >> for me, I will just trust you that it works as intended. > > Gah! However, thanks!
Does what it says on the box. Good work!
Reviewed-by: Joel Stanley <joel@jms.id.au>
| |