lkml.org 
[lkml]   [2016]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] iio: ad5755: fix off-by-one on devnr limit check
From
Date
On 21/08/16 21:07, Lars-Peter Clausen wrote:
> On 08/21/2016 09:30 PM, Jonathan Cameron wrote:
>> On 25/07/16 23:40, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The comparison for devnr limits is off-by-one, the current check
>>> allows 0 to AD5755_NUM_CHANNELS and the limit should be in fact
>>> 0 to AD5755_NUM_CHANNELS - 1. This can lead to an out of bounds
>>> write to pdata->dac[devnr]. Fix this by replacing > with >= on the
>>> comparison.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> Lars?
>>
>> Looks correct to me.
>>
>> I'd also like a fixes tag for this if possible. Guessing it
>> might well be the original driver introduction but best to be
>> sure ;)
>
> It's new in 4.8-rc1. It was introduced by the devictree support patch.
>
> Fixes: c947459979c6 ("iio: ad5755: add support for dt bindings")
Thanks Lars,

Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.034 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site