lkml.org 
[lkml]   [2016]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks
On Wed, Aug 24, 2016 at 05:15:54PM +0300, Alexander Shishkin wrote:
> @@ -221,10 +245,13 @@ static void __bts_event_start(struct perf_event *event)
>
> /*
> * local barrier to make sure that ds configuration made it
> - * before we enable BTS
> + * before we enable BTS and bts::state goes ACTIVE
> */
> wmb();
>
> + /* INACTIVE/STOPPED -> ACTIVE */
> + WRITE_ONCE(bts->state, BTS_STATE_ACTIVE);
> +
> intel_pmu_enable_bts(config);
>
> }

Alexander, were you going to post a new version of this patch without
the barrier confusion?

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:1.569 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site