Messages in this thread Patch in this message | | | From | SF Markus Elfring <> | Subject | [PATCH] powerpc: Use kmalloc_array() in grow() | Date | Mon, 29 Aug 2016 08:00:26 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 29 Aug 2016 07:50:33 +0200
* A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- arch/powerpc/lib/rheap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/lib/rheap.c b/arch/powerpc/lib/rheap.c index 94058c2..1630764 100644 --- a/arch/powerpc/lib/rheap.c +++ b/arch/powerpc/lib/rheap.c @@ -54,7 +54,7 @@ static int grow(rh_info_t * info, int max_blocks) new_blocks = max_blocks - info->max_blocks; - block = kmalloc(sizeof(rh_block_t) * max_blocks, GFP_ATOMIC); + block = kmalloc_array(max_blocks, sizeof(*block), GFP_ATOMIC); if (block == NULL) return -ENOMEM; -- 2.9.3
| |