Messages in this thread | | | Date | Mon, 29 Aug 2016 00:30:56 -0400 (EDT) | Subject | Re: [PATCH 4/5] net_sched: fix use of uninitialized ethertype variable in cls_flower | From | David Miller <> |
| |
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 26 Aug 2016 17:25:45 +0200
> The addition of VLAN support caused a possible use of uninitialized > data if we encounter a zero TCA_FLOWER_KEY_ETH_TYPE key, as pointed > out by "gcc -Wmaybe-uninitialized": > > net/sched/cls_flower.c: In function 'fl_change': > net/sched/cls_flower.c:366:22: error: 'ethertype' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This changes the code to only set the ethertype field if it > was nonzero, as before the patch. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 9399ae9a6cb2 ("net_sched: flower: Add vlan support")
Applied.
| |