lkml.org 
[lkml]   [2016]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] media: usb: dvb-usb: fix DIBUSB_MB usage of dib3000mc functions
Date
From: Randy Dunlap <rdunlap@infradead.org>

The problem is that this driver uses a "common" driver supplement
which calls a few dib3000mc*() functions but that driver is not
"select"ed by DVB_USB_DIBUSB_MB. We can fix the build errors by
selecting DVB_DIB3000MC (at the expense of around 8 KB on x86_64)
just to add a few "library-like" functions.

Or someone can split the required functions into a separate
buildable file, but for such an ancient driver, I don't see the
need to do this.

Fixes these build errors:

drivers/built-in.o: In function `dibusb_dib3000mc_frontend_attach':
(.text+0x1a63bd): undefined reference to `dib3000mc_pid_parse'
drivers/built-in.o: In function `dibusb_dib3000mc_frontend_attach':
(.text+0x1a63c5): undefined reference to `dib3000mc_pid_control'
drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
(.text+0x1a6610): undefined reference to `dib3000mc_set_config'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Joe Perches <joe@perches.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
---
drivers/media/usb/dvb-usb/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- lnx-48-rc3.orig/drivers/media/usb/dvb-usb/Kconfig
+++ lnx-48-rc3/drivers/media/usb/dvb-usb/Kconfig
@@ -34,6 +34,7 @@ config DVB_USB_DIBUSB_MB
depends on DVB_USB
select DVB_PLL if MEDIA_SUBDRV_AUTOSELECT
select DVB_DIB3000MB
+ select DVB_DIB3000MC
select MEDIA_TUNER_MT2060 if MEDIA_SUBDRV_AUTOSELECT
help
Support for USB 1.1 and 2.0 DVB-T receivers based on reference designs made by
\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.022 / U:1.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site