lkml.org 
[lkml]   [2016]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] i2c: tegra: Add runtime power-management support

> > You could have left the original 'return' instead of the 2 new ones, but
> > you decide.
>
> Yes I know, but I wanted to ensure for runtime-pm we only return 0 on
> success. Yes clk_enable should only return 0 on success and a negative
> error code otherwise, but I prefer this. So will leave as-is.

OK.

>
> >> - if (tegra_i2c_flush_fifos(i2c_dev))
> >> - err = -ETIMEDOUT;
> >> + err = tegra_i2c_flush_fifos(i2c_dev);
> >
> > 'err' is assigned but where is it checked?
>
> It will be returned by the function. This is no different to how it
> works today if you look at the code. I did think about checking it right

I agree. I missed it before, thanks for the heads up.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-09-17 09:57    [W:1.547 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site