Messages in this thread | | | Date | Thu, 25 Aug 2016 17:44:33 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization |
| |
On Thu, Aug 25, 2016 at 12:17:53PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 25, 2016 at 03:59:43PM +0200, Jiri Olsa escreveu: > > On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote: > > > > SNIP > > > > > > After applying patch: > > > > > > > > $ ./perf probe -x ./test 'foo i' > > > > $ cat /sys/kernel/debug/tracing/uprobe_events > > > > p:probe_test/foo /home/ravi/test:0x0000000000000541 i=-4(%bp):s32 > > > > > > > > $ ./perf record -e probe_test:foo ./test > > > > $ ./perf script > > > > test 6300 [001] 5877.879327: probe_test:foo: (400541) i=42 > > > > > > > > No need to skip prologue for optimized case since debug info is correct > > > > for each instructions for -O2 -g. For more details please visit: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=612253#c6 > > > > > > > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> > > > > > > Looks good for me:) > > > > > > Acked-by: Masami Hiramatsu <mhiramat@kernel.org> > > > > > > Jiri, Michael, please try this. Ravi's patch can fix your problem. > > > > yes, that fixes the problem for me > > Ok, so I'll add a Tested-by: Jiri, ok? And push it via perf/urgent.
yep, thanks
jirka
| |