Messages in this thread | | | Subject | Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk | From | Andy Shevchenko <> | Date | Thu, 25 Aug 2016 15:55:58 +0300 |
| |
On Wed, 2016-08-24 at 16:33 +0800, Kefeng Wang wrote: > It should check the data->pclk, not data->clk when get apb_pclk. > > Fixes: c8ed99d4f6a8("serial: 8250_dw: Add support for deferred > probing") > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
pclk is optional on Intel platforms. With your patch we always will get EPROBE_DEFER that obviously breaks things.
> --- > drivers/tty/serial/8250/8250_dw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c > b/drivers/tty/serial/8250/8250_dw.c > index e199696..b022f5a 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -462,7 +462,7 @@ static int dw8250_probe(struct platform_device > *pdev) > } > > data->pclk = devm_clk_get(&pdev->dev, "apb_pclk"); > - if (IS_ERR(data->clk) && PTR_ERR(data->clk) == -EPROBE_DEFER) > { > + if (IS_ERR(data->pclk) && PTR_ERR(data->pclk) == > -EPROBE_DEFER) { > err = -EPROBE_DEFER; > goto err_clk; > }
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |