Messages in this thread | | | Date | Thu, 25 Aug 2016 11:13:52 +0200 | From | Jan Kasprzak <> | Subject | Re: wan-cosa: Use memdup_user() rather than duplicating its implementation |
| |
SF Markus Elfring wrote: : > What about the GFP_DMA attribute, which your patch deletes? : > The buffer in question has to be ISA DMA-able. : : Thanks for your constructive feedback. : : Would you be interested in using a variant of the function "memdup_…" : with which the corresponding memory allocation option can be preserved?
I am not sure that extending an in-kernel API just for one legacy driver is what we want. As I said, I would prefer the driver unchanged, if possible.
Maybe it is the time for gradually phasing out ISA DMA support and all the legacy drivers which use it?
Sincerely,
-Yenya
-- | Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> | | http://www.fi.muni.cz/~kas/ GPG: 4096R/A45477D5 | Like most things in Windows, on the surface it looks great. -- Jeremy Allison, A Tale of Two Standards
| |