lkml.org 
[lkml]   [2016]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 09/10] reset: zynq: add driver Kconfig option
    2016-08-25 2:48 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
    > 2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
    >> Visible only if COMPILE_TEST is enabled, this allows to include the
    >> driver in build tests.
    >>
    >> Cc: Moritz Fischer <moritz.fischer@ettus.com>
    >> Cc: Michal Simek <michal.simek@xilinx.com>
    >> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
    >> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
    >> ---
    >> drivers/reset/Kconfig | 6 ++++++
    >> drivers/reset/Makefile | 2 +-
    >> 2 files changed, 7 insertions(+), 1 deletion(-)
    >>
    >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
    >> index 17030e2..86b49a2 100644
    >> --- a/drivers/reset/Kconfig
    >> +++ b/drivers/reset/Kconfig
    >> @@ -67,6 +67,12 @@ config RESET_SUNXI
    >> help
    >> This enables the reset driver for Allwinner SoCs.
    >>
    >> +config RESET_ZYNQ
    >> + bool "ZYNQ Reset Driver" if COMPILE_TEST
    >> + default ARCH_ZYNQ
    >> + help
    >> + This enables the reset driver for Xilinx Zynq FPGAs.
    >> +
    >
    > Please move this below RESET_UNIPHIER
    > as I assume you are sorting Kconfig entries alphabetically.
    >
    >
    > Otherwise,
    >
    > Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    >




    >> + This enables the reset driver for Xilinx Zynq FPGAs.


    One more thing, I thought this statement is not precise
    because Zynq is not only an FPGA,
    but ARM SoC + FPGA.

    Please consider to reword

    "This enables the reset driver for Xilinx Zynq SoC"






    --
    Best Regards
    Masahiro Yamada

    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:5.479 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site