lkml.org 
[lkml]   [2016]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings
On Wed, Aug 24, 2016 at 05:53:00PM +0530, Vinay Simha wrote:
> if we do not set the polarity to 8mA, panel will have gibberish display.
> (information to set 8mA is available only in
> nexus7-msm-flo-3.4-lollipop-release_dsi kernel nx7 release)
>
> i will add this
> reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;

I don't think that will work with the current driver, because the GPIO
subsystem will automatically invert the value for you. Currently the
panel driver sets the GPIO value to 0 to assert the reset. With the
GPIO_ACTIVE_LOW flag you'd end up setting the actual level of the GPIO
to high, which is going to deassert. So I think if you make the above
change (which I think is the right thing to do), you'll also have to
update the driver to use high-active logic.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.842 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site