lkml.org 
[lkml]   [2016]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] hwrng: amd: Be consitent with the driver name
    On Fri, Aug 19, 2016 at 03:42:55PM +0200, LABBE Corentin wrote:
    > The driver name is displayed each time differently.
    > This patch make use of the same name everywhere.
    >
    > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
    > ---
    > drivers/char/hw_random/amd-rng.c | 13 ++++++-------
    > 1 file changed, 6 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c
    > index d0042f5..d0a806a 100644
    > --- a/drivers/char/hw_random/amd-rng.c
    > +++ b/drivers/char/hw_random/amd-rng.c
    > @@ -31,7 +31,7 @@
    > #include <linux/delay.h>
    > #include <asm/io.h>
    >
    > -#define PFX KBUILD_MODNAME ": "
    > +#define DRV_NAME "AMD768-HWRNG"
    >
    > /*
    > * Data for PCI driver interface
    > @@ -98,7 +98,7 @@ static void amd_rng_cleanup(struct hwrng *rng)
    > }
    >
    > static struct hwrng amd_rng = {
    > - .name = "amd",
    > + .name = DRV_NAME,

    Hmm, this changes a sysfs-exported name which has the potential
    to break user-space. So I think you'd need to a stronger argument
    to do it other than just cleaning it up.

    Cheers,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:3.551 / U:0.844 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site