Messages in this thread Patch in this message | | | From | Artem Savkov <> | Subject | [PATCH] Make __xfs_xattr_put_listen preperly report errors. | Date | Tue, 23 Aug 2016 17:54:13 +0200 |
| |
Commit "xfs: only return -errno or success from attr ->put_listent" changes the returnvalue of __xfs_xattr_put_listen to 0 in case when there is insufficient space in the buffer assuming that setting context->count to -1 would be enough, but all of the ->put_listent callers only check seen_enough. This results in a failed assertion: XFS: Assertion failed: context->count >= 0, file: fs/xfs/xfs_xattr.c, line: 175 in insufficient buffer size case.
Signed-off-by: Artem Savkov <asavkov@redhat.com> --- fs/xfs/xfs_xattr.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c index ea62245..6290093 100644 --- a/fs/xfs/xfs_xattr.c +++ b/fs/xfs/xfs_xattr.c @@ -147,6 +147,7 @@ __xfs_xattr_put_listent( arraytop = context->count + prefix_len + namelen + 1; if (arraytop > context->firstu) { context->count = -1; /* insufficient space */ + context->seen_enough = 1; return 0; } offset = (char *)context->alist + context->count; -- 2.7.4
| |