lkml.org 
[lkml]   [2016]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 4/8] usb: core: add power sequence handling for USB devices
On Tue, 23 Aug 2016, Peter Chen wrote:

> I will add #ifdef CONFIG_OF for related code. And put the content at
> hub_pwrseq_on at hub_probe directly, how about below?
>
> hub_probe() {
>
> ...
>
> if (hub_configure(hub, endpoint) >= 0) {
> #ifdef CONFIG_OF
> for_each_child_of_node(parent->of_node, np) {
> ret = generic_pwrseq_on(np, hub);
> if (ret)
> return ret;
> }
> #else
> return 0;
> #endif
> }

Please make this a separate subroutine like you had before, but now in
hub.c:

#ifdef CONFIG_OF
static int hub_of_pwrseq_on(struct usb_hub *hub)
{
...
}

#else
static inline int hub_of_pwrseq_on(struct usb_hub *hub)
{
return 0;
}
#endif /* CONFIG_OF */


Alan Stern

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.057 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site