Messages in this thread | | | Subject | Re: [RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from <linux/types.h>") | From | Christian König <> | Date | Mon, 22 Aug 2016 10:58:28 +0200 |
| |
Am 22.08.2016 um 10:48 schrieb Emil Velikov: > > Although last time around people leaned towards the __uX types, if we > have a consensus amongst drm (kernel) developers about using stdint > ones everything should be fine. > We just need a handful of acks from the different maintainers.
For the record I always clearly voted for the C99 stdint types instead of the kernel ones.
> That said, _note_ that some applications are built with -C89 -pedantic > [1] which means that using stdint.h may or may not work as expected. > So we'll want a __STDC_VESION__ check + #error in case of pre-C99 ? > If the affected programs are proprietary ones we should be safe, > otherwise we want to update them ~alongside the transition.
While it is theoretical possible I don't think we have any applications which actually do this, cause they would have been broken before as well.
Regards, Christian.
> > Thanks > Emil > > [1] > https://cgit.freedesktop.org/mesa/drm/commit/?id=0f4452bb51306024fbf4cbf77d8baab20cefba67 > https://cgit.freedesktop.org/mesa/drm/commit/?id=d20314d083e533e3b8753192b1846752341afbbe > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
| |