Messages in this thread | | | Date | Sun, 21 Aug 2016 18:26:21 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 4/4] rtl8712: pwrctrl_priv: Replace semaphore lock with mutex |
| |
On Thu, Jun 02, 2016 at 09:54:10AM +0530, Binoy Jayan wrote: > The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it > should be written as one. Semaphores are going away in the future. > _enter_pwrlock was using down_interruptible(), so the lock could be broken > by sending a signal. This could be a bug, because nothing checks the return > code here. Hence, using mutex_lock instead of the interruptible version. > Removing the now unused _enter_pwrlock and _down_sema. > > Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org> > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > Tested-by: Larry Finger <Larry.Finger@lwfinger.net> > --- > This patch depends on the following patch: > rtl8712: intf_priv: Replace semaphore lock with completion
This one patch doesn't apply to my tree for some odd reason.
Can you rebase it on my staging-testing branch and resend it?
thanks,
greg k-h
| |