lkml.org 
[lkml]   [2016]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 176/180] ALSA: oxygen: Fix logical-not-parentheses warning
    Date
    From: Tomer Barletz <barletz@gmail.com>

    commit 8ec7cfce3762299ae289c384e281b2f4010ae231 upstream.

    This fixes the following warning, that is seen with gcc 5.1:
    warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses].

    Signed-off-by: Tomer Barletz <barletz@gmail.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    sound/pci/oxygen/oxygen_mixer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
    index c0dbb52..1e4bcb9 100644
    --- a/sound/pci/oxygen/oxygen_mixer.c
    +++ b/sound/pci/oxygen/oxygen_mixer.c
    @@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl,
    int changed;

    mutex_lock(&chip->mutex);
    - changed = !value->value.integer.value[0] != chip->dac_mute;
    + changed = (!value->value.integer.value[0]) != chip->dac_mute;
    if (changed) {
    chip->dac_mute = !value->value.integer.value[0];
    chip->model.update_dac_mute(chip);
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.023 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site