lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues
    On Tue, 2 Aug 2016 22:12:33 -0500
    Josh Poimboeuf <jpoimboe@redhat.com> wrote:


    > Sounds good. I was thinking I could also add a similar define to
    > indicate whether an arch passes the return address stack pointer to
    > ftrace_push_return_trace(). HAVE_FUNCTION_GRAPH_RET_ADDR_PTR?
    >

    If you are making this function global, might as well make all pass
    that pointer when you do the conversion. I don't think we need a define
    to differentiate it.

    -- Steve

    \
     
     \ /
      Last update: 2016-08-03 06:01    [W:3.106 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site