Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() | Date | Tue, 02 Aug 2016 11:50:48 -0700 |
| |
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> writes:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > simple-card-utils might be used as module, but MODULE_xxx() > information was missed. This patch adds it. > Otherwise, we will have below error, and can't use it. > Specil thanks to Kevin. > >> insmod simple-card-utils.ko > simple_card_utils: module license 'unspecified' taints kernel. > Disabling lock debugging due to kernel taint > simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) > simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) > insmod: can't insert 'simple-card-utils.ko': \ > unknown symbol in module, or unknown parameter > > Reported-by: Kevin Hilman <khilman@baylibre.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > >>> Kevin > > Thank you for your report. I think this patch can solve your issue. > Can you check this ?
Your patch works, but as Mark pointed out, I didn't think that this was the right fix as this isn't a module, but just library.
Kevin
| |