lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()
On Tue, Aug 02, 2016 at 03:22:08AM +0000, Kuninori Morimoto wrote:

> +MODULE_AUTHOR("Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>");
> +MODULE_DESCRIPTION("ALSA SoC Simple Card Utils");
> +MODULE_LICENSE("GPL v2");

This lot is what is needed (well, just the MODULE_LICENSE).

> +MODULE_ALIAS("platform:asoc-simple-card-utils");

This is wrong, this isn't a driver but rather a library that's used by
other modules so it shouldn't have an alias. The aliases are there to
let modutils know which module to load for a device that it sees.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-08-02 21:01    [W:1.707 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site