Messages in this thread | | | Date | Tue, 2 Aug 2016 11:33:59 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 1/7] tools lib: Add bitmap_alloc function |
| |
On Mon, Aug 01, 2016 at 12:45:18PM -0600, David Ahern wrote: > On 8/1/16 12:02 PM, Jiri Olsa wrote: > > @@ -65,4 +66,13 @@ static inline int test_and_set_bit(int nr, unsigned long *addr) > > return (old & mask) != 0; > > } > > > > +/** > > + * bitmap_alloc - Allocate bitmap > > + * @nr: Bit to set > > + */ > > +static inline unsigned long *bitmap_alloc(int nbits) > > +{ > > + return malloc(BITS_TO_LONGS(nbits) * sizeof(unsigned long)); > > +} > > + > > #endif /* _PERF_BITOPS_H */ > > calloc? Can't imagine any user wanting an uninitialized bitmap.
hum, right.. all my code used bitmap_zero, but zalloc would be better choice in here
thanks, jirka
| |