lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 0582/1285] Replace numeric parameter like 0444 with macro
    Date
    I find that the developers often just specified the numeric value
    when calling a macro which is defined with a parameter for access permission.
    As we know, these numeric value for access permission have had the corresponding macro,
    and that using macro can improve the robustness and readability of the code,
    thus, I suggest replacing the numeric parameter with the macro.

    Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
    Signed-off-by: Baole Ni <baolex.ni@intel.com>
    ---
    drivers/media/usb/cx231xx/cx231xx-i2c.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c
    index 473cd34..a15b99e 100644
    --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c
    +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c
    @@ -32,11 +32,11 @@
    /* ----------------------------------------------------------- */

    static unsigned int i2c_scan;
    -module_param(i2c_scan, int, 0444);
    +module_param(i2c_scan, int, S_IRUSR | S_IRGRP | S_IROTH);
    MODULE_PARM_DESC(i2c_scan, "scan i2c bus at insmod time");

    static unsigned int i2c_debug;
    -module_param(i2c_debug, int, 0644);
    +module_param(i2c_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
    MODULE_PARM_DESC(i2c_debug, "enable debug messages [i2c]");

    #define dprintk1(lvl, fmt, args...) \
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-08-02 19:01    [W:2.302 / U:0.672 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site