Messages in this thread | | | Date | Tue, 2 Aug 2016 15:32:42 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH 0261/1285] Replace numeric parameter like 0444 with macro |
| |
On Tue, Aug 02, 2016 at 06:54:18PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> > Signed-off-by: Baole Ni <baolex.ni@intel.com> > ---
Thanks, Acked-by: Leon Romanovsky <leonro@mellanox.com>
> drivers/infiniband/hw/mlx5/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c > index b48ad85..3ae01dc 100644 > --- a/drivers/infiniband/hw/mlx5/main.c > +++ b/drivers/infiniband/hw/mlx5/main.c > @@ -65,7 +65,7 @@ MODULE_LICENSE("Dual BSD/GPL"); > MODULE_VERSION(DRIVER_VERSION); > > static int deprecated_prof_sel = 2; > -module_param_named(prof_sel, deprecated_prof_sel, int, 0444); > +module_param_named(prof_sel, deprecated_prof_sel, int, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(prof_sel, "profile selector. Deprecated here. Moved to module mlx5_core"); > > static char mlx5_version[] = > -- > 2.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [unhandled content-type:application/pgp-signature] | |