lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Fix build failture on perl script context
Em Tue, Aug 02, 2016 at 11:12:32AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Aug 02, 2016 at 11:03:02PM +0900, Namhyung Kim escreveu:
> > What I did to fix is adding '-Wno-shadow' as the error message said
> > it's the cause of the failure. Since it's from the perl (not perf)
> > code base, we don't have the control so I just wanted to ignore the
> > warning when compiling perl scripting code.
> >
> > Is it ok for you?
>
> Now it is :-)
>
> I'll stick this to the changeset log as the reason for adding
> -wno-shadow just for building the perl code.
>
> Sometimes we'll get to this conclusion after some thinking, if you add
> these explanations to the changelog then it speeds up reviewing.

Cool, this fixed the build as well for fedora rawhide.

- Arnaldo

\
 
 \ /
  Last update: 2016-08-02 18:01    [W:0.072 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site