lkml.org 
[lkml]   [2016]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [kernel-hardening] [PATCH v3 0/5] bug: Provide toggle for BUG on data corruption
    On Thu, Aug 18, 2016 at 10:53:18PM -0400, Rik van Riel wrote:
    > On Thu, 2016-08-18 at 13:57 -0700, Paul E. McKenney wrote:
    > > On Thu, Aug 18, 2016 at 01:42:55PM -0400, Rik van Riel wrote:
    > > > On Wed, 2016-08-17 at 14:42 -0700, Kees Cook wrote:
    > > > > This adds CONFIG_BUG_ON_DATA_CORRUPTION to trigger BUG()s when
    > > > > the
    > > > > kernel
    > > > > encounters unexpected data structure integrity as currently
    > > > > detected
    > > > > with CONFIG_DEBUG_LIST.
    > > > >=20
    > > > > Specifically list operations have been a target for widening
    > > > > flaws to
    > > > > gain
    > > > > "write anywhere" primitives for attackers, so this also
    > > > > consolidates
    > > > > the
    > > > > debug checking to avoid code and check duplication (e.g. RCU list
    > > > > debug
    > > > > was missing a check that got added to regular list debug). It
    > > > > also
    > > > > stops
    > > > > manipulations when corruption is detected, since worsening the
    > > > > corruption
    > > > > makes no sense. (Really, everyone should build with
    > > > > CONFIG_DEBUG_LIST
    > > > > since the checks are so inexpensive.)
    > > > >=20
    > > > > This is mostly a refactoring of similar code from PaX and
    > > > > Grsecurity,
    > > > > along with MSM kernel changes by Syed Rameez Mustafa.
    > > > >=20
    > > > > Along with the patches is a new lkdtm test to validate that
    > > > > setting
    > > > > CONFIG_DEBUG_LIST actually does what is desired.
    > > >=20
    > > > Series looks good to me, too.
    > >=20
    > > Reviewed-by?=C2=A0=C2=A0Acked-by?=C2=A0=C2=A0Ephemeral accolades?=C2=A0=
    > =C2=A0;-)
    >
    > Acked-by: Rik van Riel <riel@redhat.com>
    >
    > works, but I saw you already committed the series to
    > your tree, and was not sure you would add more reviews :)

    Well, there is at least one more rebase for topic branches. ;-)

    Thanx, Paul

    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:2.190 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site