lkml.org 
[lkml]   [2016]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 3/7] power: act8945a_charger: Add status change update support
Hi,

On Fri, Aug 19, 2016 at 09:13:31AM +0800, Wenyou Yang wrote:
> - Fix the 'dev' argument of devm_request_irq() to pdev->dev.parent.

This is not a fix.

> + ret = devm_request_irq(pdev->dev.parent, irq, act8945a_status_changed,
> + IRQF_TRIGGER_FALLING, "act8945a_interrupt",
> + charger);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to request nIRQ pin IRQ\n");
> + return ret;
> + }

This will result in the irq not being free'd during device remove,
but when the parent device is removed.

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-09-17 09:57    [W:1.891 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site