lkml.org 
[lkml]   [2016]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Cocci] Coccinelle: Script to replace allocate and memset with zalloc functions
From
Date
>> I suggest to take another look at a few implementation details.
>>
>> 1. Would it make sense to merge such SmPL rules into one
>> so that code duplication could be reduced a bit
>> in such a script?
>>
>> 2. How do you think about to extend the shown check list
>> with the function "kvm_kvzalloc"?

> kvm_kvzalloc function doesn't fit the same pattern as the other
> functions in this semantic patch, and is kvm specific,

Has this one got a similar function property?

Do you prefer to exclude such functions which belong to subsystems
so far generally?


> so the semantic patch looks fine as is.

How do you think about to express the shown source code repetition
as an aspect by an other script format?

Regards,
Markus

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.077 / U:1.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site