lkml.org 
[lkml]   [2016]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] acpi, nfit: fix acpi event notifications for nfit
On Thu, Aug 18, 2016 at 12:52 PM, Linda Knippers <linda.knippers@hpe.com> wrote:
>
>
> On 8/18/2016 3:48 PM, Dan Williams wrote:
>> On Thu, Aug 18, 2016 at 11:48 AM, Vishal Verma <vishal.l.verma@intel.com> wrote:
>>> The nfit driver had an acpi event notification handler, but it never
>>> would've worked because we weren't setting the
>>> ACPI_DRIVER_ALL_NOTIFY_EVENTS flag in acpi_driver.
>>
>> Let's update the changelog to be helpful for someone implementing a
>> backport or taking this back to a -stable branch. Something like:
>>
>> Subject: acpi, nfit: fix event notifications
>>
>> Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added
>> support for _FIT notifications, but it neglected to set the
>> ACPI_DRIVER_ALL_NOTIFY_EVENTS flag that acpi_bus_notify() uses to gate
>> notification delivery.
>
> While we're at it, should we update the notifier function to explicitly check
> for event 0x80 before re-evaluating the _FIT? I'm thinking about some time
> in the future when there might be more than one event.

Yes, good idea.

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:1.065 / U:1.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site