lkml.org 
[lkml]   [2016]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/16] mm: writeback: Convert to hotplug state machine
    Date
    Install the callbacks via the state machine and let the core invoke
    the callbacks on the already online CPUs.

    Cc: Tejun Heo <tj@kernel.org>
    Cc: Jens Axboe <axboe@fb.com>
    Cc: linux-mm@kvack.org
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    ---
    include/linux/cpuhotplug.h | 1 +
    mm/page-writeback.c | 26 +++++++-------------------
    2 files changed, 8 insertions(+), 19 deletions(-)

    diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
    index 82ee32107dff..854e59a426d4 100644
    --- a/include/linux/cpuhotplug.h
    +++ b/include/linux/cpuhotplug.h
    @@ -16,6 +16,7 @@ enum cpuhp_state {
    CPUHP_X86_APB_DEAD,
    CPUHP_VIRT_NET_DEAD,
    CPUHP_SLUB_DEAD,
    + CPUHP_MM_WRITEBACK_DEAD,
    CPUHP_WORKQUEUE_PREP,
    CPUHP_POWER_NUMA_PREPARE,
    CPUHP_HRTIMERS_PREPARE,
    diff --git a/mm/page-writeback.c b/mm/page-writeback.c
    index 82e72524db55..6d3d0e87f309 100644
    --- a/mm/page-writeback.c
    +++ b/mm/page-writeback.c
    @@ -2050,26 +2050,12 @@ void writeback_set_ratelimit(void)
    ratelimit_pages = 16;
    }

    -static int
    -ratelimit_handler(struct notifier_block *self, unsigned long action,
    - void *hcpu)
    +static int page_writeback_cpu_online(unsigned int cpu)
    {
    -
    - switch (action & ~CPU_TASKS_FROZEN) {
    - case CPU_ONLINE:
    - case CPU_DEAD:
    - writeback_set_ratelimit();
    - return NOTIFY_OK;
    - default:
    - return NOTIFY_DONE;
    - }
    + writeback_set_ratelimit();
    + return 0;
    }

    -static struct notifier_block ratelimit_nb = {
    - .notifier_call = ratelimit_handler,
    - .next = NULL,
    -};
    -
    /*
    * Called early on to tune the page writeback dirty limits.
    *
    @@ -2092,8 +2078,10 @@ void __init page_writeback_init(void)
    {
    BUG_ON(wb_domain_init(&global_wb_domain, GFP_KERNEL));

    - writeback_set_ratelimit();
    - register_cpu_notifier(&ratelimit_nb);
    + cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "MM_WRITEBACK_ONLINE",
    + page_writeback_cpu_online, NULL);
    + cpuhp_setup_state(CPUHP_MM_WRITEBACK_DEAD, "MM_WRITEBACK_DEAD", NULL,
    + page_writeback_cpu_online);
    }

    /**
    --
    2.9.3
    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.105 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site